Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending message with attachments #1088

Merged

Conversation

EgorovEI
Copy link
Contributor

What was solved?
This PR fixes the case when OutgoingMessage stored in messagesSection did not include attachment object after sending. It led to the situation when the attachment was missed if initial send message request failed.
Now failed-to-send messages with attachments can be successfully resent.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

@EgorovEI
Copy link
Contributor Author

!squash

This commit fixes the case when OutgoingMessage stored in messagesSection did not include attachment object. It led to the situation when the attachment was missed if initial send message request failed.

MOB-3724
@sm-deployer sm-deployer force-pushed the fix/MOB-3724-message-with-attachments-retry-logic branch from 44611c8 to be239ec Compare October 24, 2024 06:40
@EgorovEI EgorovEI merged commit a7c4e17 into development Oct 24, 2024
8 checks passed
@EgorovEI EgorovEI deleted the fix/MOB-3724-message-with-attachments-retry-logic branch October 24, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants