Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new public interfaces to the Entry Widget #1075

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add new public interfaces to the Entry Widget #1075

merged 1 commit into from
Oct 21, 2024

Conversation

rasmustautsglia
Copy link
Contributor

@rasmustautsglia rasmustautsglia commented Oct 18, 2024 •
edited
Loading

What was solved?
Add new public interaces to EntryWidget. We now have a clear distinction between the sheet interfaces and the embedded one.

MOB-3409
Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@igorkravchenko igorkravchenko force-pushed the feature/entry-widget-and-secure-conversations-v2 branch 2 times, most recently from f4300ab to ef727e2 Compare October 21, 2024 07:22
@rasmustautsglia rasmustautsglia force-pushed the Add-new-public-interfaces-for-EntryWidget branch from 7b43148 to 66341d4 Compare October 21, 2024 07:35
@rasmustautsglia rasmustautsglia merged commit 8aa8770 into feature/entry-widget-and-secure-conversations-v2 Oct 21, 2024
7 of 8 checks passed
@rasmustautsglia rasmustautsglia deleted the Add-new-public-interfaces-for-EntryWidget branch October 21, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorovEI EgorovEI EgorovEI approved these changes

@igorkravchenko igorkravchenko igorkravchenko approved these changes

@ykyivskyi-gl ykyivskyi-gl Awaiting requested review from ykyivskyi-gl

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasmustautsglia @igorkravchenko @EgorovEI