Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry widget localization #1071

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Entry widget localization #1071

merged 1 commit into from
Oct 22, 2024

Conversation

AndriiHorishniiMOC
Copy link

https://glia.atlassian.net/browse/MOB-3607

What was solved?
Add new localizations for the Entry Widget and replace the hardcoded strings with them in the Entry Widget.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

igorkravchenko
igorkravchenko approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merge conflict. Other than that looks good to me.

@AndriiHorishniiMOC AndriiHorishniiMOC force-pushed the task/MOB-3607_entry_widget_localization branch from 7709179 to c422aa4 Compare October 17, 2024 08:14
@rasmustautsglia rasmustautsglia force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from cdf1e06 to cac42b4 Compare October 17, 2024 11:07
@igorkravchenko igorkravchenko force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from aed3878 to 0228f93 Compare October 17, 2024 15:49
@igorkravchenko
Copy link
Contributor

@AndriiHorishniiMOC you will need to rebase current branch on top of feature/entry-widget-and-secure-conversations-v2

@igorkravchenko igorkravchenko force-pushed the feature/entry-widget-and-secure-conversations-v2 branch 2 times, most recently from f4300ab to ef727e2 Compare October 21, 2024 07:22
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from ed763eb to 68ade5b Compare October 22, 2024 10:52
@EgorovEI EgorovEI force-pushed the task/MOB-3607_entry_widget_localization branch from 6d91b5d to 27f5d4b Compare October 22, 2024 10:55
@AndriiHorishniiMOC AndriiHorishniiMOC force-pushed the task/MOB-3607_entry_widget_localization branch from 27f5d4b to 26efaab Compare October 22, 2024 11:28
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 68ade5b to e0349d0 Compare October 22, 2024 11:31
@EgorovEI EgorovEI force-pushed the task/MOB-3607_entry_widget_localization branch from 26efaab to 05eeb4f Compare October 22, 2024 11:32
@EgorovEI EgorovEI force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from e0349d0 to 6606af7 Compare October 22, 2024 12:06
@AndriiHorishniiMOC
Add new localizations for the Entry Widget.
4a50bb5 
Add new localizations for the Entry Widget and replace the hardcoded strings with them in the Entry Widget.

MOB-3607
@EgorovEI EgorovEI force-pushed the task/MOB-3607_entry_widget_localization branch from 05eeb4f to 4a50bb5 Compare October 22, 2024 12:07
@AndriiHorishniiMOC AndriiHorishniiMOC merged commit eb4f39f into feature/entry-widget-and-secure-conversations-v2 Oct 22, 2024
8 checks passed
@AndriiHorishniiMOC AndriiHorishniiMOC deleted the task/MOB-3607_entry_widget_localization branch October 22, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasmustautsglia rasmustautsglia rasmustautsglia approved these changes

@igorkravchenko igorkravchenko igorkravchenko approved these changes

@ykyivskyi-gl ykyivskyi-gl Awaiting requested review from ykyivskyi-gl

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriiHorishniiMOC @igorkravchenko @rasmustautsglia