Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility identifiers to 'submit' and 'cancel' survey buttons #1057

Conversation

igorkravchenko
Copy link
Contributor

In order to ensure in acceptance tests that survey gets shown when engagement ended by operator in background, survey_cancel_button and survey_submit_button accessibility identifiers must be assigned to relevant buttons.

MOB-3612

What was solved?

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

Screenshots:

In order to ensure in acceptance tests that survey gets shown when engagement ended by operator in background, survey_cancel_button and survey_submit_button accessibility identifiers must be assigned to relevant buttons.

MOB-3612
@igorkravchenko igorkravchenko merged commit 36fb09f into development Oct 2, 2024
8 checks passed
@igorkravchenko igorkravchenko deleted the task/MOB-3612-acc-identifiers-for-initial-survey-buttons branch October 2, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants