-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EngagementLauncher logic #1055
Implement EngagementLauncher logic #1055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about unit tests and code comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from unit tests, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think EngagementLauncherTests
can be improved by making tests a bit deeper involving property engagement
on Glia
instance to be asserted instead of local variables, like chatEngagement
etc.
GliaWidgetsTests/Sources/Glia/GliaTests+EngagementLauncher.swift
Outdated
Show resolved
Hide resolved
GliaWidgetsTests/Sources/EngagementLauncher/EngagementLauncherTests.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
!squash |
b9452a7
to
724c729
Compare
996e729
into
feature/entry-widget-and-secure-conversations-v2
What was solved?
This PR implements EngagementLauncher logic and splits start engagement logic to two phases(setup and coordinator start).
Release notes:
Additional info:
Screenshots: