Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EngagementLauncher logic #1055

Conversation

ykyivskyi-gl
Copy link
Contributor

What was solved?
This PR implements EngagementLauncher logic and splits start engagement logic to two phases(setup and coordinator start).

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

Screenshots:

Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about unit tests and code comments.

Copy link
Contributor

@rasmustautsglia rasmustautsglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from unit tests, looks good

Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think EngagementLauncherTests can be improved by making tests a bit deeper involving property engagement on Glia instance to be asserted instead of local variables, like chatEngagement etc.

Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ykyivskyi-gl
Copy link
Contributor Author

!squash

@sm-deployer sm-deployer force-pushed the Implement-engagement-launcher-logic branch from b9452a7 to 724c729 Compare October 2, 2024 15:31
@ykyivskyi-gl ykyivskyi-gl merged commit 996e729 into feature/entry-widget-and-secure-conversations-v2 Oct 2, 2024
8 checks passed
@ykyivskyi-gl ykyivskyi-gl deleted the Implement-engagement-launcher-logic branch October 2, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants