Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Engagement Launcher interface and getter from Glia #1052

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Add Engagement Launcher interface and getter from Glia #1052

merged 1 commit into from
Sep 26, 2024

Conversation

ykyivskyi-gl
Copy link
Contributor

What was solved?
This PR introduces Engagement Launcher interface and adds Launcher's constructor to Glia instance.

MOB-3473

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

igorkravchenko
igorkravchenko reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some suggestions. There are also related linter warnings for this interface.

GliaWidgets/Sources/EngagementLauncher/EngagementLauncher.swift Show resolved Hide resolved
GliaWidgets/Public/Glia/Glia+EngagementLauncher.swift Outdated Show resolved Hide resolved
GliaWidgets/Public/Glia/Glia+EngagementLauncher.swift Outdated Show resolved Hide resolved
@ykyivskyi-gl ykyivskyi-gl force-pushed the Add-engagement-launcher-interface branch 2 times, most recently from 11a0de0 to a45d6f1 Compare September 26, 2024 09:19
@ykyivskyi-gl
Copy link
Contributor Author

!squash

@sm-deployer sm-deployer force-pushed the Add-engagement-launcher-interface branch from a45d6f1 to f4dee5f Compare September 26, 2024 11:05
EgorovEI
EgorovEI reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@EgorovEI EgorovEI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix swiftlint warnings in EngagementLauncher.swift

@ykyivskyi-gl
Copy link
Contributor Author

!squash

@sm-deployer sm-deployer force-pushed the Add-engagement-launcher-interface branch from 1b5e571 to f1440bc Compare September 26, 2024 13:19
@ykyivskyi-gl ykyivskyi-gl merged commit bd25f43 into feature/entry-widget-and-secure-conversations-v2 Sep 26, 2024
8 checks passed
@ykyivskyi-gl ykyivskyi-gl deleted the Add-engagement-launcher-interface branch September 26, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasmustautsglia rasmustautsglia rasmustautsglia approved these changes

@EgorovEI EgorovEI EgorovEI approved these changes

@igorkravchenko igorkravchenko igorkravchenko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykyivskyi-gl @igorkravchenko @EgorovEI @rasmustautsglia