Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test commit #38

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Test commit #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ related changes can not be expected to have come from the same commit.

This approach has gained popularity since GitHub added this option to their PR
merge button. And it does avoid the problem of completeness introduced by the
previous approach, but it has it's own problems. When a PR is very small, then
previous approach, but it has its own problems. When a PR is very small, then
this approach actually works amazingly well. It breaks down, however, when a PR
has a bit more going on. Its main problem is that it breaks the rule which
states that commits should be [focused][2], they should only do _one thing_ (a
Expand Down