-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO NEED TO REVIEW NOW] Feature/entry widget and secure conversations v2 #1133
Draft
andrews-moc
wants to merge
49
commits into
development
Choose a base branch
from
feature/entry-widget-and-secure-conversations-v2
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[NO NEED TO REVIEW NOW] Feature/entry widget and secure conversations v2 #1133
andrews-moc
wants to merge
49
commits into
development
from
feature/entry-widget-and-secure-conversations-v2
+5,819
−5,418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate Call and Chat Activities to Kotlin - Refactor CallConfiguration - Refactor EngagementConfiguration MOB 3587
- Moved all the Intent-related functionality to the IntentHelper class. - Abstraction will let us to easily mock this layer. MOB 3582
- Create ActivityLauncher - Rename FilePreview... classes to ImagePreview... MOB 3589
- Create interfaces for EngagementLauncher - Create basic ConfigurationManager that should hold all the init config MOB 3588
This custom attributes can be setup by integrators in their theme.xml
This is needed so that customise glia theme settings in integrators theme.xml
- Remove all the configurations in favor of ConfigurationManager - Get rid of configurations passed through Activity extras - Move extra keys to internal class - Make activities internal - Minor refactoring
Texts have changed, updating according to the Figma designs. MOB-3615
…idget Setup queues each time get Entry Widget is called MOB-3408
…g to design MOB-3478
…led in Example App settings MOB-3657
…is not authenticated MOB-3659
…t queues should be used MOB-3657
This change is directly related to changes in Core SDK regarding OkHttp version. See salemove/android-sdk#763 MOB-3661
These changes are to make secure conversations align with new UI designs. Part of Secure Conversations V2 project. MOB-3621
Make changes to the getView() interface based on the discussions MOB-3702, MOB-3694
…tController MOB-3703, MOB-3715
MOB-3408
…t is available but visitor is not authenticated Hide the 'Try Again' button if SDK is not initialized MOB-3712 MOB-3728
Designers have requested that small adjustments be made to secure the conversation's welcome screen based on SCv2 project designes. MOB-3631
Part of secure conversation v2 project MOB-3633
Apply default attributes from GliaTheme to the Entry Widget view in the XML layer. MOB-3601
DavDo
force-pushed
the
feature/entry-widget-and-secure-conversations-v2
branch
from
November 1, 2024 11:12
8ae0b3e
to
c866c9d
Compare
Previously, we showed an Alert Dialog that said that secure messaging was unavailable, but now it should be a label above the chat EditText view. MOB-3635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-xxx
What was solved?
Release notes:
Additional info:
Screenshots: