Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve chat_view.xml layout preview #1128

Open
wants to merge 2 commits into
base: feature/entry-widget-and-secure-conversations-v2
Choose a base branch
from
Open

Improve chat_view.xml layout preview #1128

wants to merge 2 commits into from
+126 −120

Conversation

gugalo
Copy link
Collaborator

@gugalo gugalo commented Oct 23, 2024

Jira issue:

  • no ticket -

What was solved?
These changes were made specifically to preview chat_view.xml. Here are some key points:

  • AppBarView and its sub-views were throwing NullPointException because of Dependencies.localeProvider
  • Added dummy content for the GvaChipGroup view

Release notes:

  • Feature
  • Ignore: no effect for client
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

Before
Screenshot 2024-10-23 at 15 43 54

After
Screenshot 2024-10-23 at 15 45 25

@gugalo gugalo requested a review from a team as a code owner October 23, 2024 13:01
@DavDo
Copy link
Collaborator

DavDo commented Oct 23, 2024

Good Idea! 👍

Base automatically changed from feature/MOB-3633 to feature/entry-widget-and-secure-conversations-v2 October 30, 2024 11:02
@DavDo DavDo force-pushed the feature/entry-widget-and-secure-conversations-v2 branch from 8ae0b3e to c866c9d Compare November 1, 2024 11:12
@gugalo
Improve chat_view.xml layout preview
ac4fe4d 
These changes were made specifically to preview chat_view.xml. Here are some key points:
- AppBarView and its sub-views were throwing NullPointException because of `Dependencies.localeProvider`
- Added dummy content for the `GvaChipGroup` view
@gugalo
Fix paparazzi having problems with locales
053d773 
The issue that this commit is solving is related to custom views with View.isInEditMode flag for LocaleProvider
@gugalo
Copy link
Collaborator Author

gugalo commented Nov 7, 2024 •
edited
Loading

Added new commit to fix issues with locales in snapshot test. They have been failing again because of View.isInEditMode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriiHorishniiMOC AndriiHorishniiMOC Awaiting requested review from AndriiHorishniiMOC

@DavDo DavDo Awaiting requested review from DavDo

@andrews-moc andrews-moc Awaiting requested review from andrews-moc

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gugalo @DavDo @andrews-moc