Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLDC] Only enable rotor offset compensation when hall interpolation … #45

Merged
merged 1 commit into from
Dec 31, 2023
Merged

[BLDC] Only enable rotor offset compensation when hall interpolation … #45

merged 1 commit into from
Dec 31, 2023

Commits on Dec 31, 2023

  1. [BLDC] Only enable rotor offset compensation when hall interpolation … 

    …is enabled

The commit enabling sector offset compensation accidentally made some poor unit tests wherein the raw hall angle was not passed through if interpolation was disabled.

This feature should only be active if interpolation is also active, otherwise it does not make sense to actually enable this feature.

Fix adds a param flag for this and also fixes the unit tests to ensure raw hall angle passthrough
    @sahil-kale
    sahil-kale committed Dec 31, 2023
    Configuration menu
    Copy the full SHA
    c79d6a6 View commit details
    Browse the repository at this point in the history