Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Python 3.9 #154

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Require Python 3.9 #154

merged 3 commits into from
Mar 17, 2024

Commits on Mar 16, 2024

  1. Require Python 3.9

    build with Python 3.8 seems to fail with
    
    ```
    In file included from /home/conda/feedstock_root/build_artifacts/cypari2_1705557903378/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/python3.8/pytime.h:6,
                       from /home/conda/feedstock_root/build_artifacts/cypari2_1705557903378/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/python3.8/Python.h:85,
                       from cypari2/convert.c:50:
      cypari2/pycore_long.h: In function '_PyLong_SetSignAndDigitCount':
      cypari2/pycore_long.h:92:13: error: 'o' undeclared (first use in this function); did you mean 'op'?
         92 |     Py_SIZE(o) = size;
            |
    ```
    
    also our CI only tests with Python 3.9+ so that seem to be required by
    now.
    
    In any case, active support for Python 3.8 ended May 2021 and security
    support is going to end in October 2024.
    mkoeppe committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    c011b3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    694c9e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bbd1105 View commit details
    Browse the repository at this point in the history