Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple types of proxies #1380

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Support multiple types of proxies #1380

merged 1 commit into from
Oct 14, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Oct 10, 2024

  • Until now, Safe only supported Safe Proxies
  • Now ERC-1167 and ERC-1967 proxies are also supported

@coveralls
Copy link

coveralls commented Oct 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11291868974

Details

  • 122 of 126 (96.83%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 93.602%
Changes Missing Coverage Covered Lines Changed/Added Lines %
safe_eth/eth/proxies/proxy.py 19 20 95.0%
safe_eth/eth/proxies/standard_proxy.py 17 20 85.0%
Totals Coverage Status
Change from base Build 11273382511: 0.05%
Covered Lines: 8924
Relevant Lines: 9534
💛 - Coveralls

@Uxio0 Uxio0 self-assigned this Oct 11, 2024
@Uxio0 Uxio0 marked this pull request as ready for review October 11, 2024 11:56
@Uxio0 Uxio0 requested a review from a team as a code owner October 11, 2024 11:56
moisses89
moisses89 approved these changes Oct 11, 2024
View reviewed changes
safe_eth/eth/proxies/minimal_proxy.py Outdated
)

@cache
def get_singleton_address(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can or we would like to reuse this to other proxy implementations, could we call instead get_singleton_address call it as get_implementation_address?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, done

@Uxio0
Support multiple types of proxies
21bfaa4 
- Until now, Safe only supported Safe Proxies
- Now ERC-1167 and ERC-1967 proxies are also supported
@Uxio0 Uxio0 merged commit f016644 into main Oct 14, 2024
6 checks passed
@Uxio0 Uxio0 deleted the implement-multiple-proxies branch October 14, 2024 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees

@Uxio0 Uxio0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uxio0 @coveralls @moisses89