Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import importing twice #181

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Fix import importing twice #181

wants to merge 1 commit into from

Conversation

birdddev
Copy link
Collaborator

Also removes the <TargetBox> from the Import dock.
TargetBox is completely un-used now.

Also removes the <TargetBox> from the import dock
@rvion
Copy link
Owner

rvion commented Feb 29, 2024

Can we still import import workflows or images by drag and dropping anything anywhere in the app ? I thought it would be cool if we had a global drop handler on the whole app itself

@birdddev
Copy link
Collaborator Author

You already have it going to the document.body as well useGlobalDropHook, which is the one that actually handles all of the file types, TargetBox only did images, not urls it looked like.
It was good you mentioned you set up the url dragging, because I initially commented out useGlobalDropHook first and then tested it and it only worked for files.

@birdddev
Copy link
Collaborator Author

birdddev commented Feb 29, 2024

This broke dragging images from inside cushy though.
May just have to move the useGlobal stuff to TargetBox, I'll look in to it later 😔

@birdddev birdddev marked this pull request as draft February 29, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants