Update to wgpu 0.19, cross-platform #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Jan 21, 2024
na-winit-wgpu/README.md
Outdated
Comment on lines
38
to
39
| export ANDROID_NDK_HOME="path/to/ndk" | ||
| export ANDROID_SDK_HOME="path/to/sdk" |
There was a problem hiding this comment.
I copied it from the cargo APK instructions; doesn't xbuild have a dependency on Android SDK/NDK?
There was a problem hiding this comment.
I wouldn't copy that, the tools are quite different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been very difficult to get wgpu to work (especially on older devices), so I'm sharing my result.
Now that Android and WASM support has improved in all crates, I managed to support all platforms with the latest crate versions.
I know the intention of this repository is Android, but I believe having a ready-to-go example with cross-platform instructions is critical to support both developers and libraries on this new platform.
Unfortunately I don't have time to update all examples, but I think it's best to at least update this one for now.
I'm not sure about the web-sys features but it seems to support webgl and webgpu like this.
I set present_mode to fifo and alpha_mode to opaque, because that's what worked on my Android 8.1 device and is probably more widely supported. I left the other options commented out.
I also moved the rendering to App. Perhaps App should also get an input(event) and tick/update() function.
I also introduced WGPU_BACKEND as a compile time variable.
I also commented out the unnecessary request_redraw, with a comment that one could use it for animation.