Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test case for #131164 #132036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a test case for #131164 #132036

wants to merge 1 commit into from
+20 −0

Conversation

DianQK
Copy link
Member

@DianQK DianQK commented Oct 22, 2024

The upstream has already been fixed, but it won't be backported to LLVM 19.

r? jieyouxu or compiler

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu
jieyouxu approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you can r=me after PR CI is green.

@jieyouxu
Copy link
Member

@bors delegate+

@bors
Copy link
Contributor

bors commented Oct 22, 2024

✌️ @DianQK, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 22, 2024

📌 Commit ff00622 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#132036 - DianQK:test-131164, r=jieyouxu
b87c8d6 
Add a test case for rust-lang#131164

The upstream has already been fixed, but it won't be backported to LLVM 19.

r? jieyouxu or compiler
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 22, 2024
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2024
@bors
Auto merge of rust-lang#132042 - matthiaskrgr:rollup-eloj566, r=matth…
abf7479 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#132002 (abi/compatibility: also test Option-like types)
 - rust-lang#132026 (analyse: remove unused uncanonicalized field)
 - rust-lang#132036 (Add a test case for rust-lang#131164)
 - rust-lang#132040 (relnotes: fix stabilizations of `assume_init`)

r? `@ghost`
`@rustbot` modify labels: rollup
@DianQK
Copy link
Member Author

DianQK commented Oct 22, 2024

#132042 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DianQK @rustbot @jieyouxu @bors