Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core::ops::Bound::from_opt API #131998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krtab
Copy link
Contributor

@krtab krtab commented Oct 21, 2024

This is a proposition for a new API for core::ops::Bound.

Use cases are provided in the doc examples.

Let me know if this needs an ACP/RCP.

@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2024

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 21, 2024
@krtab
Copy link
Contributor Author

krtab commented Oct 22, 2024

We may prefer to have the signature be pub fn from_opt_xxx<U: Into<T>>(opt: Option<U>) -> Bound<T> instead of the current pub fn from_opt_xxx(opt: Option<T>) -> Bound<T>.

@thomcc
Copy link
Member

thomcc commented Oct 23, 2024

I think this needs an ACP.

@thomcc thomcc added the needs-acp This change is blocked on the author creating an ACP. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-acp This change is blocked on the author creating an ACP. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants