Optimise Msrv for common one item case #13472
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Msrv
is cloned around a lot in order to handle the#[clippy::msrv]
attribute. This attribute, however, meansRustcVersion
will be heap allocated if there is only one source of an msrv (eg:rust-version
inCargo.toml
).This PR optimizes for said case, while keeping the external interface the same by:
RustVersion
inline for the common one element case.ThinVec
to shrinkMsrv
to 16 bytes, from 24, to optimize for the zero and one element cases.changelog: none