Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new lint unneeded_struct_pattern #13465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new lint unneeded_struct_pattern #13465

wants to merge 1 commit into from

Conversation

SpriteOvO
Copy link
Contributor

Closes #13400.

changelog: [unneeded_struct_pattern]: Add new lint

@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Centri3 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 26, 2024
@SpriteOvO SpriteOvO force-pushed the unneeded_struct_pattern branch 5 times, most recently from d1a94c7 to 4733775 Compare September 26, 2024 19:55
alex-semenyuk
alex-semenyuk reviewed Sep 30, 2024
View reviewed changes
clippy_lints/src/unneeded_struct_pattern.rs Outdated
"struct pattern is not needed for a unit variant",
"remove the struct pattern",
String::new(),
Applicability::Unspecified,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppose it can be MachineApplicable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. 👍

@SpriteOvO SpriteOvO force-pushed the unneeded_struct_pattern branch 2 times, most recently from 3b45390 to 36b1025 Compare October 2, 2024 07:16
@bors
Copy link
Collaborator

bors commented Oct 13, 2024

☔ The latest upstream changes (presumably #13334) made this pull request unmergeable. Please resolve the merge conflicts.

@SpriteOvO
Copy link
Contributor Author

Rebased. r? @alex-semenyuk

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

Failed to set assignee to alex-semenyuk: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-semenyuk alex-semenyuk alex-semenyuk left review comments

Assignees

@Centri3 Centri3

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encourage removing { .. } from a pattern if enum variant is field-less
5 participants
@SpriteOvO @rustbot @bors @alex-semenyuk @Centri3