feat: Add publishing of nightly Rust versions #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Docker Hub publishing is performed by the rustopsbot account: https://hub.docker.com/u/rustopsbot. I think T-infra owns it? I vaguely remember them setting up the ghcr token as well. |
|
LGTM otherwise though. |
What do you mean by this? Are you saying this should be merged now, or should I merge it once we get the publishing setup with |
|
I'd probably wait until we get the tokens so the build won't be failing every night. |
|
I've created a new token for the rustopsbot user on Docker Hub and added it as the |
|
Let's land it! |
Muscraft
force-pushed
the
add-nightly
branch
2 times, most recently
from
8428286
to
2f3e421
Compare
|
I commented out the parts for publishing to GitHub packages, so that we can at least land the publishing to Docker |
tyranron
added a commit
to instrumentisto/rust-docker-image
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The images for nightly versions of
rust, produced byrust-lang/docker-rust-nightlyhave diverged significantly over time, and recently stopped being published nightly. Seeing both of these things, it would make sense to move allrustrelated docker images to be managed within one repo. This has the benefit of ensuring we keep the images in sync while having one spot to look at in case of problems.Merging this PR will not immediately make the nightly images get published from here. We do not have a secret for Docker hub, as well as the images published to ghcr.io/rust-lang/rust are still tied to
docker-rust-nightlyand will need to be moved (if possible).