Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: Adjust "Failed to run job" error logging #9687

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 18, 2024

Adding the error details as a structured logging field isn't actually as useful. Let's revert this back to regular stringification.

Adding the error details as a structured logging field isn't actually as useful. Let's revert this back to regular stringification.
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 18, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) October 18, 2024 09:38
@Turbo87 Turbo87 merged commit 73f8cbe into rust-lang:main Oct 18, 2024
8 checks passed
@Turbo87 Turbo87 deleted the error-logging branch October 18, 2024 09:48
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.72%. Comparing base (087d070) to head (77c6be7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/crates_io_worker/src/worker.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9687   +/-   ##
=======================================
  Coverage   88.71%   88.72%           
=======================================
  Files         287      287           
  Lines       29338    29336    -2     
=======================================
  Hits        26027    26027           
+ Misses       3311     3309    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant