Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker/jobs: Move index-related jobs into dedicated modules #9576

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 4, 2024

This PR splits up the worker/jobs/git module into several per-job modules, which should make the files slightly more maintainable. It also renames the parent module from git to index, since the code also deals with the sparse index, which is not git-based.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 4, 2024
@Turbo87 Turbo87 enabled auto-merge October 4, 2024 09:50
@Turbo87 Turbo87 merged commit 0837f0b into rust-lang:main Oct 4, 2024
8 checks passed
@Turbo87 Turbo87 deleted the jobs branch October 4, 2024 10:01
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 29.28571% with 99 lines in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (2d33f01) to head (f693720).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/worker/jobs/index/normalize.rs 0.00% 63 Missing ⚠️
src/worker/jobs/index/squash.rs 0.00% 35 Missing ⚠️
src/worker/jobs/index/sync.rs 97.61% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9576   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files         287      289    +2     
  Lines       29051    29051           
=======================================
  Hits        25890    25890           
  Misses       3161     3161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant