Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers/token: Replace BytesRequest with Json extractor #9564

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 2, 2024

The only reason for using BytesRequest is to provide a custom error message, but I question whether that is actually that useful here...

@Turbo87 Turbo87 requested a review from a team October 2, 2024 16:14
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (4b95c44) to head (b822c04).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9564   +/-   ##
=======================================
  Coverage   89.11%   89.12%           
=======================================
  Files         285      285           
  Lines       28923    28925    +2     
=======================================
+ Hits        25775    25778    +3     
+ Misses       3148     3147    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 merged commit 1d87349 into rust-lang:main Oct 4, 2024
10 checks passed
@Turbo87 Turbo87 deleted the bytes-req branch October 4, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant