Move features to feature2 that depend on features that use new feature syntax
#9551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
commented
Oct 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9551 +/- ##
==========================================
+ Coverage 89.07% 89.11% +0.04%
==========================================
Files 286 287 +1
Lines 28940 29053 +113
==========================================
+ Hits 25779 25892 +113
Misses 3161 3161 ☔ View full report in Codecov by Sentry. |
Turbo87
force-pushed
the
split-features
branch
from
67a52fc
to
e27c821
Compare
Turbo87
force-pushed
the
split-features
branch
from
e27c821
to
187b3c9
Compare
This was referenced Oct 4, 2024
|
👋🏾! Is the migration of this done for all relevant crate index files. |
|
@weihanglo yes and no. we only triggered a manual sync for clap. the other crates will update whenever they release a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6135. Closes #6168.
Compared to #6168, this PR implements the fix in a way that features depending on newer syntax are recursively moved to
features2instead of moving them all unconditionally.Probably best reviewed commit-by-commit :)
/cc @rust-lang/cargo