Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for provisioning a Windows box to run crater #423

Merged
merged 1 commit into from
Jul 21, 2019

Conversation

ecstatic-morse
Copy link
Contributor

This adds detailed set-up instructions for running crater on a Windows box. Obviously this depends on #399. I also tried to explain some of the complexity around Docker image compatibility.

@pietroalbini
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 21, 2019

📌 Commit 88a765f has been approved by pietroalbini

@bors
Copy link
Contributor

bors commented Jul 21, 2019

⌛ Testing commit 88a765f with merge bfa27d7...

bors added a commit that referenced this pull request Jul 21, 2019
Add steps for provisioning a Windows box to run `crater`

This adds detailed set-up instructions for running `crater` on a Windows box. Obviously this depends on #399. I also tried to explain some of the complexity around Docker image compatibility.
@bors
Copy link
Contributor

bors commented Jul 21, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing bfa27d7 to master...

@bors bors merged commit 88a765f into rust-lang:master Jul 21, 2019

## Operating System

The agent machine should run Windows Server build 1803 (Windows 10 build 1803
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to mention up here that Windows 10 Build 1809 and above will work.

Copy link
Contributor Author

@ecstatic-morse ecstatic-morse Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's now an officially published 1803 image that's hard-coded as the default, so I think the mention down below is sufficient. I meant for this paragraph to be the bare minimum of information for someone to get up and running with the stock set up, and if you wanna use 1809 you'll need to build your own docker image and pass it to crater.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I need to add, "later versions of Windows will work, but you'll need to use a custom Docker image, see below".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea that's enough.

isolation and Hyper-V isolation. Hyper-V isolation is more secure and more
flexible, but it is too slow for our purposes; it essentially spins up a VM for
each container. In order to run process isolation, the build number of the
agent machine and the docker image [need to match][ver-compat]. You can use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to say "for example, if you're using Build 1803, you can find the image here"

Copy link
Contributor Author

@ecstatic-morse ecstatic-morse Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll add a link to the official image. As well as instructions for building a custom one.

@ecstatic-morse ecstatic-morse deleted the windows-docs branch September 10, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants