-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add steps for provisioning a Windows box to run crater
#423
Conversation
@bors r+ Thanks! |
📌 Commit 88a765f has been approved by |
Add steps for provisioning a Windows box to run `crater` This adds detailed set-up instructions for running `crater` on a Windows box. Obviously this depends on #399. I also tried to explain some of the complexity around Docker image compatibility.
☀️ Test successful - checks-travis, status-appveyor |
|
||
## Operating System | ||
|
||
The agent machine should run Windows Server build 1803 (Windows 10 build 1803 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea to mention up here that Windows 10 Build 1809 and above will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's now an officially published 1803 image that's hard-coded as the default, so I think the mention down below is sufficient. I meant for this paragraph to be the bare minimum of information for someone to get up and running with the stock set up, and if you wanna use 1809 you'll need to build your own docker image and pass it to crater
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I need to add, "later versions of Windows will work, but you'll need to use a custom Docker image, see below".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea that's enough.
isolation and Hyper-V isolation. Hyper-V isolation is more secure and more | ||
flexible, but it is too slow for our purposes; it essentially spins up a VM for | ||
each container. In order to run process isolation, the build number of the | ||
agent machine and the docker image [need to match][ver-compat]. You can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to say "for example, if you're using Build 1803, you can find the image here"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll add a link to the official image. As well as instructions for building a custom one.
This adds detailed set-up instructions for running
crater
on a Windows box. Obviously this depends on #399. I also tried to explain some of the complexity around Docker image compatibility.