Fix return type of Kernerl#y which is added by psych #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that Kernel#y returns nil from the beginning. - https://github.com/ruby/psych/blob/b051cf80bcafa6776fe3e3ac4b230c18bea3e95b/lib/psych/core_ext.rb#L12-L16 - https://github.com/ruby/psych/blob/045b31104754579c61bb5d2df9395a055cbb3354/lib/psych/y.rb#L5-L7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
psych gem によって追加される Kernel#y について、実装当初も今も、String を返すのではなく標準出力に出力する実装になっていました。これを受けてドキュメントの方を修正しました。