Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recommendTimeRangeConverter function case month and year #2089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gb853940223
Copy link

recommendTimeRangeConverter方法中,LAST_1_MONTH和LAST_1_YEAR的计算逻辑有问题。比如,LAST_1_MONTH应该是过去一个月,正确的计算结果应该为[上一个月的当时日期,当时日期],而不是[当月第一天,当月最后一天]。LAST_1_YEAR同理

@Cuiyansong
Copy link
Contributor

Cuiyansong commented Feb 8, 2023

LGTM 👍,确实应该是这样的逻辑,后期需要补测试涵盖日期范围逻辑。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants