Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

feat(GenomeAnnotationReader): Reader of NCBI's genome annotetion at nuccore databases #689

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

acpguedes
Copy link

Description

I included a new reader to read NCBI's genome annotation. It receive a species name and search the organism against NCBI's nuccore databases and return a array of genome annotation of this species to multiple strains.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • [ x] New Loader/Tool
  • Bug fix / Smaller change
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • [ x] I stared at the code and made sure it makes sense

Suggested Checklist:

  • [ x] I have added a library.json file if a new loader/tool was added
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • [ x] I ran make format; make lint to appease the lint gods

image

Re-doing PR of #676

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! some minor comments before landing:

  • also do we need changes to waii.ipynb?

.gitignore Show resolved Hide resolved
llama_hub/genome/README.md Show resolved Hide resolved
llama_hub/genome/base.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@jerryjliu
Copy link
Collaborator

@acpguedes quick bump on this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants