Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

JSONReader: Encoding fixes UnicodeDecodeError #665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

freinold
Copy link

Description

Provides additional encoding parameter in JSONReader, default is UTF-8.
Fixes "UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 3445: character maps to " on Windows 10 x64

Type of Change

Please delete options that are not relevant.

  • Bug fix / Smaller change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Provides additional encoding parameter, default is UTF-8
@anoopshrma
Copy link
Collaborator

Hi @freinold, Thankyou for the contribution.

Could you also please take a look at linting!

Copy link
Collaborator

@EmanuelCampos EmanuelCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! could you help fix the lint errors? make format; make lint

i can get to it but just not right now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants