Add/update headers for all active files, add pre-commit #142
Conversation
|
There's a few conflicts, please rebase |
There was a problem hiding this comment.
There are many more shortcomings, like not handling existing licences in triple-quoted strings, removing useful comments, not treating utils as a local import, bundling other smaller fixes together in the same commit.
Plus I’m concerned about having to maintain the same files across different repositories.
These are all fixable, no problem.
We can pull just the 'add_header' script from the main repo if we don't want to bother with maintaining that file in particular. As for the ruff toml, it's different enough that I think it's worth the work. Same goes for a pre-commit, but I'm a sucker for automation. |
Download the add-header script from the main repo, apply it to the probes outside of the attic
Add ruff config that follows the main repo requirements, but includes utils as a local folder import
Add a pre-commit that matches the main repo requirements. Runs the add-header shell script instead of the py version
* Rucio is a first party, utils is a local folder.
voetberg
force-pushed
the
pre_commit_and_header
branch
from
be8ac5b
to
8dd1980
Compare
Addresses #141
Looks huge but it's just sorting imports according to the ruff settings from the main repo and adding headers to everything except probes in the attic. Doesn't address any of the concerns the pre-commits (either flake8 or ruff) bring up.