Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address fixture path deprecation warnings #357

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Address fixture path deprecation warnings #357

merged 1 commit into from
Mar 16, 2024

Conversation

cjlarose
Copy link
Member

@cjlarose cjlarose commented Mar 16, 2024 •
edited
Loading

Fixes deprecation warning in Rails 7.1

DEPRECATION WARNING: TestFixtures#fixture_path is deprecated and will be removed in Rails 7.2. Use #fixture_paths instead.
If multiple fixture paths have been configured with #fixture_paths, then #fixture_path will just return
the first path.

Since the test suite supports older Rails versions and fixtures_paths was introduced in Rails 7.1, we continue to call fixture_path unless fixtures_path is available.

@cjlarose cjlarose force-pushed the address-fixture-path-deprecation-warnings branch from 6786663 to b8cc1eb Compare March 16, 2024 07:04
@cjlarose cjlarose merged commit 9c23cbb into rubyconfig:master Mar 16, 2024
8 checks passed
noxasch pushed a commit to noxasch/config that referenced this pull request Mar 16, 2024
@cjlarose @noxasch
Silence deprecation warnings for fixture_path in Rails >= 7.1 (rubyco…
8d9c05c 
…nfig#357)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjlarose @pkuczynski