Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return empty string when token_stream is nil #1056

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

toshimaru
Copy link
Contributor

@toshimaru toshimaru commented Nov 19, 2023

The change in #1055 could be a breaking change (see. #1055 (comment)).

As a simple workaround, return empty string when token_stream is nil.

Additionally, a test for test_token_stream has been added.

@toshimaru toshimaru marked this pull request as ready for review November 20, 2023 00:02
The change in ruby#1055 might be a breaking change.
So, just simply wrap `token_stream` with `Array`

Co-authored-by: Jonathan Hefner <[email protected]>
lib/rdoc/token_stream.rb Outdated Show resolved Hide resolved
@toshimaru toshimaru changed the title fix: return token_stream.to_s when token_stream is nil fix: Return empty string when token_stream is nil Nov 28, 2023
@toshimaru toshimaru requested a review from nobu November 28, 2023 00:51
@hsbt hsbt merged commit 04f75d8 into ruby:master Dec 5, 2023
19 checks passed
@toshimaru toshimaru deleted the follow-up-1055 branch December 6, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants