Set valid consumes if file parameter #882
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceraccoon
force-pushed
the
spaceraccoon-handle-file-parameter-type
branch
from
ba881bc
to
eba6cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #881, this adds a check if any of the parameters are of
filetype and ifconsumesis not set to eitherapplication/x-www-form-urlencodedormultipart/form-data, it will set it to both in accordance to the OpenAPI v2 spec that only allows these values forfileparameters. It will also set all other parameters in the method toformDataasformDataandbodyparameters cannot both be in the same method. Currently, by default if afileparameter is included, theconsumeswill be set to an invalidapplication/json.