[Fix #384] Support optimized String#dup for Performance/UnfreezeString
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reezeString` Resolves rubocop#384. This PR supports optimized `String#dup` for `Performance/UnfreezeString` when Ruby 3.3+. To incorporate rubocop/rubocop@d11e25f the RuboCop dependency will be updated to 1.48.1+ from 1.30.0+, but the supported runtime Ruby version will keep at Ruby 2.6+. - https://rubygems.org/gems/rubocop/versions/1.30.0 - https://rubygems.org/gems/rubocop/versions/1.48.1
koic
force-pushed
the
support_optimized_string_dup_for_performance_unfreeze_string
branch
from
0c426d6
to
7ac5b60
Compare
koic
deleted the
support_optimized_string_dup_for_performance_unfreeze_string
branch
koic
added a commit
that referenced
this pull request
Mar 4, 2024
koic
added a commit
to koic/rubocop-rails-omakase
that referenced
this pull request
Nov 3, 2024
This PR removes `Performance/UnfreezeString` cop. Starting with Ruby 3.3, the aim of this cop to improve performance by replacing `String#dup` with `String#+@` no longer holds meaning. - rubocop/rubocop-performance#384 - rubocop/rubocop-performance#418 Currently, Rails 8.0 (rc2) supports Ruby 3.2 and above, but support for Ruby 3.2 will likely be dropped in a future version of Rails. When that time comes, any use of `String#+@` instead of `String#dup` at the application layer will be unnecessary. Since this is enforced for performance rather than style, I think it makes sense to disable this cop. This is a suggestion to disable a cop that will eventually become irrelevant, from the perspective of maintaining RuboCop Performance. I understand that rubocop-rails-omakase does not expect configuration changes, so please feel free to close this if it doesn’t fit.
jeremy
pushed a commit
to rails/rubocop-rails-omakase
that referenced
this pull request
Nov 3, 2024
This PR removes `Performance/UnfreezeString` cop. Starting with Ruby 3.3, the aim of this cop to improve performance by replacing `String#dup` with `String#+@` no longer holds meaning. - rubocop/rubocop-performance#384 - rubocop/rubocop-performance#418 Currently, Rails 8.0 (rc2) supports Ruby 3.2 and above, but support for Ruby 3.2 will likely be dropped in a future version of Rails. When that time comes, any use of `String#+@` instead of `String#dup` at the application layer will be unnecessary. Since this is enforced for performance rather than style, I think it makes sense to disable this cop. This is a suggestion to disable a cop that will eventually become irrelevant, from the perspective of maintaining RuboCop Performance. I understand that rubocop-rails-omakase does not expect configuration changes, so please feel free to close this if it doesn’t fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #384.
This PR supports optimized
String#dupforPerformance/UnfreezeStringwhen Ruby 3.3+.To incorporate rubocop/rubocop@d11e25f the RuboCop dependency will be updated to 1.48.1+ from 1.30.0+, but the supported runtime Ruby version will keep at Ruby 2.6+.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.