Fix a false negative for Performance/ReverseEach when safe navigati…

…on is between `reverse` and `each`
rubocop · Nov 25, 2023 · 1f9237a · 1f9237a
1 parent 4a4fb1d
commit 1f9237a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/changelog/fix_false_negative_for_reverse_each.md b/changelog/fix_false_negative_for_reverse_each.md
@@ -0,0 +1 @@
+* [#390](https://github.com/rubocop/rubocop-performance/issues/390): Fix a false negative for `Performance/ReverseEach` when safe navigation is between `reverse` and `each`. ([@fatkodima][])
diff --git a/lib/rubocop/cop/performance/reverse_each.rb b/lib/rubocop/cop/performance/reverse_each.rb
@@ -27,7 +27,7 @@ class ReverseEach < Base
         RESTRICT_ON_SEND = %i[each].freeze
 
         def_node_matcher :reverse_each?, <<~MATCHER
-          (send (call _ :reverse) :each)
+          ({send csend} (call _ :reverse) :each)
         MATCHER
 
         def on_send(node)

diff --git a/spec/rubocop/cop/performance/reverse_each_spec.rb b/spec/rubocop/cop/performance/reverse_each_spec.rb
@@ -12,6 +12,8 @@
     expect_offense(<<~RUBY)
       array&.reverse.each { |e| puts e }
              ^^^^^^^^^^^^ Use `reverse_each` instead of `reverse.each`.
+      array&.reverse&.each { |e| puts e }
+             ^^^^^^^^^^^^^ Use `reverse_each` instead of `reverse.each`.
     RUBY
   end