allow limiting number of concurrent runs #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running all test classes and methods at once consumes a lot of CPU/RAM/network, that might cause problems on weak machines with large amount of tests
KazankovMarch
commented
Aug 5, 2023
| suspend fun Semaphore?.withPermitIfNotNull(block: suspend () -> Unit) = if(this != null) { | ||
| withPermit { block() } | ||
| } else { | ||
| block() |
There was a problem hiding this comment.
this code is needed to avoid any overhead for those who don't want to set up the limits.
But MAYBE we should add some limits by default
KuznetsovVlad
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running all test classes and methods at once consumes a lot of CPU/RAM/network, that might cause problems on weak machines with large amount of tests
We need both semaphores I added because