Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phantom margins #426

Merged
merged 1 commit into from
May 13, 2018
Merged

Conversation

owanturist
Copy link

Hello @rtfeldman! The PR includes implementation of margin* (changes are very close to #425) rules as a part of #392

Please take a look.

Checklist

  • Each Value is an open record with a single field. The field's name is the value's name, and its type is Supported. For example foo : Value { provides | foo : Supported } There is no one new Value.
  • Each function returning Style accepts a closed record of Supported fields.
  • If a function returning Style takes a single Value, that Value should always support inherit, initial, and unset because all CSS properties support those three values! For example, borderFoo : Value { foo : Supported, bar : Supported, inherit : Supported, initial : Supported, unset : Supported } -> Style
  • If a function returning Style takes more than one Value, however, then none of its arguments should support inherit, initial, or unset, because these can never be used in conjunction with other values! For example, border-radius: 5px 5px; is valid CSS, border-radius: inherit; is valid CSS, but border-radius: 5px inherit; is invalid CSS. To reflect this, borderRadius : Value { ... } -> Style must have inherit : Supported in its record, but borderRadius2 : Value { ... } -> Value { ... } -> Style must not have inherit : Supported in either argument's record. If a user wants to get border-radius: inherit, they must call borderRadius, not borderRadius2!
  • Every exposed value has documentation which includes at least 1 code sample.
  • Documentation links to to a CSS Tricks article if available, and MDN if not.
  • Make a pull request against the phantom-types branch, not master!

@tolgap
Copy link
Collaborator

tolgap commented May 11, 2018

@owanturist It doesn't look like the auto value is supported for these properties.

@rtfeldman
Copy link
Owner

rtfeldman commented May 13, 2018

Thanks @owanturist!

Good point @tolgap - I'll add auto post-merge; very quick fix. 😄

@rtfeldman rtfeldman merged commit 891e31e into rtfeldman:phantom-types May 13, 2018
@owanturist owanturist deleted the phantom-margin branch May 14, 2018 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants