Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @rtfeldman! The PR includes implementation of
margin*
(changes are very close to #425) rules as a part of #392Please take a look.
Checklist
EachThere is no one newValue
is an open record with a single field. The field's name is the value's name, and its type isSupported
. For examplefoo : Value { provides | foo : Supported }
Value
.Style
accepts a closed record ofSupported
fields.Style
takes a singleValue
, thatValue
should always supportinherit
,initial
, andunset
because all CSS properties support those three values! For example,borderFoo : Value { foo : Supported, bar : Supported, inherit : Supported, initial : Supported, unset : Supported } -> Style
Style
takes more than oneValue
, however, then none of its arguments should supportinherit
,initial
, orunset
, because these can never be used in conjunction with other values! For example,border-radius: 5px 5px;
is valid CSS,border-radius: inherit;
is valid CSS, butborder-radius: 5px inherit;
is invalid CSS. To reflect this,borderRadius : Value { ... } -> Style
must haveinherit : Supported
in its record, butborderRadius2 : Value { ... } -> Value { ... } -> Style
must not haveinherit : Supported
in either argument's record. If a user wants to getborder-radius: inherit
, they must callborderRadius
, notborderRadius2
!phantom-types
branch, notmaster
!