Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace Stamen/Stadia in vignettes, function documentation, and inst examples #913

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

jack-davison
Copy link
Contributor

@jack-davison jack-davison commented Apr 2, 2024

This fixes #912 and a bit more.

These fixes only change the providers in examples, and anything directly associated with them (e.g., if the group was "Stamen" before it's now "Carto", and in one instance the colour of circles was changed to stand out better on a new basemap).

Re-ran devtools::document().

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024

CLA assistant check
All committers have signed the CLA.

@schloerke
Copy link
Contributor

Thank you!

@gadenbuie
Copy link
Member

@schloerke ICYMI I replied in the issue: #912 (comment). I'm in favor of cutting down on our usage of Stadia maps but we should keep at least one or two examples and we should go through the stated process of setting up domain-based auth so we can have experience with the process and also monitor how it works.

@schloerke
Copy link
Contributor

@gadenbuie Totally did. Thank you!

Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jack-davison! I added one of the Stamen examples back (under "Third-party tiles") along with some instructions on migrating to Stadia.

I also registered an account and added our rstudio.github.io domain to the allowlist, so the Stamen tiles should work as expected in our docs.

@gadenbuie gadenbuie merged commit 92bc272 into rstudio:main Apr 10, 2024
12 checks passed
@jack-davison jack-davison deleted the fix/replace-stamen-stadia branch April 11, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken basemaps on {pkgdown} site
4 participants