enables previously disabled tests (#991)

Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]>
rsocket · Feb 28, 2021 · da0c73f · da0c73f
1 parent d3ae6fa
commit da0c73f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/rsocket-core/src/test/java/io/rsocket/core/RSocketRequesterTest.java b/rsocket-core/src/test/java/io/rsocket/core/RSocketRequesterTest.java
@@ -1201,7 +1201,6 @@ public void shouldTerminateAllStreamsIfThereRacingBetweenDisposeAndRequests(
   }
 
   @Test
-  @Disabled("Reactor 3.4.0 should fix that. No need to do anything on our side")
   // see https://github.com/rsocket/rsocket-java/issues/858
   public void testWorkaround858() {
     ByteBuf buffer = rule.alloc().buffer();

diff --git a/rsocket-core/src/test/java/io/rsocket/core/RSocketResponderTest.java b/rsocket-core/src/test/java/io/rsocket/core/RSocketResponderTest.java
@@ -167,9 +167,9 @@ public Mono<Payload> requestResponse(Payload payload) {
 
   @Test
   @Timeout(2_000)
-  @Disabled
   public void testHandlerEmitsError() throws Exception {
     final int streamId = 4;
+    rule.prefetch = 1;
     rule.sendRequest(streamId, FrameType.REQUEST_STREAM);
     assertThat(
         "Unexpected frame sent.", frameType(rule.connection.awaitFrame()), is(FrameType.ERROR));
@@ -839,7 +839,6 @@ private static Stream<FrameType> refCntCases() {
   }
 
   @Test
-  @Disabled("Reactor 3.4.0 should fix that. No need to do anything on our side")
   // see https://github.com/rsocket/rsocket-java/issues/858
   public void testWorkaround858() {
     ByteBuf buffer = rule.alloc().buffer();

diff --git a/...transport-netty/src/test/java/io/rsocket/transport/netty/server/CloseableChannelTest.java b/...transport-netty/src/test/java/io/rsocket/transport/netty/server/CloseableChannelTest.java
@@ -19,7 +19,6 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatNullPointerException;
 
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import reactor.core.publisher.Mono;
@@ -57,9 +56,6 @@ void constructorNullContext() {
         .withMessage("channel must not be null");
   }
 
-  @Disabled(
-      "NettyContext isDisposed() is not accurate\n"
-          + "https://github.com/reactor/reactor-netty/issues/360")
   @DisplayName("disposes context")
   @Test
   void dispose() {