Add rr commands to remove and move traces #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocallahan
requested changes
Jul 24, 2023
src/util.h
Outdated
| * I.e. does not start with . or #, does not end with ~, is neither cpu_lock | ||
| * nor latest_trace. | ||
| */ | ||
| bool is_valid_trace_name(const std::string& entry, bool log_error=false); |
There was a problem hiding this comment.
Prefer using a dedicated enum instead of a bool parameters. Boolean parameters make the call site hard to read.
There was a problem hiding this comment.
Yeah, that function isn't pretty. If I understand you correctly, is_valid_trace_name(entry, TraceNameCheck::verbose) also doesn't seem best to me. Is a string* out param okay?
src/MvCommand.cc
Outdated
| return 1; | ||
| } | ||
|
|
||
| if (from_path == to_path) { |
There was a problem hiding this comment.
Do we need to real_path(to_path) before we make this comparison?
There was a problem hiding this comment.
I check that to_path doesn't exist and real_path requires an existing path.
But given from_path exists, I guess checking from_path==to_path is irrelevant.
rocallahan
requested changes
Jul 26, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1415, this pull request implements
rr rmandrr mvcommands to manage traces.See #3558 for a similar pull request using
std::filesystemthat was closed because that library caused build errors.