Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] More precise type hints for rosbag2_py #1463

Draft
wants to merge 8 commits into
base: humble
Choose a base branch
from
Draft

[wip] More precise type hints for rosbag2_py #1463

wants to merge 8 commits into from

Commits on Sep 8, 2023

  1. devcontainer

    @MichaelFishmanBDAII
    MichaelFishmanBDAII committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8ae29d3 View commit details
    Browse the repository at this point in the history

  2. remobed workflows so I can push to my fork

    @MichaelFishmanBDAII
    MichaelFishmanBDAII committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8bdcc96 View commit details
    Browse the repository at this point in the history

  3. tests dont rely on ROSBAG2_PY_TEST_RESOURCES_DIR in env

    @MichaelFishmanBDAII
    MichaelFishmanBDAII committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    408dcd7 View commit details
    Browse the repository at this point in the history

  4. rosbag2_py tests use unittest and TemporaryDirectory

    @MichaelFishmanBDAII
    MichaelFishmanBDAII committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    ca4809d View commit details
    Browse the repository at this point in the history

  5. Generate stubs

    @MichaelFishmanBDAII
    MichaelFishmanBDAII committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    c6b5933 View commit details
    Browse the repository at this point in the history

  6. read_next _should_ have better type hint. Doesn't seem to.

    @MichaelFishmanBDAII
    MichaelFishmanBDAII committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    98bba7a View commit details
    Browse the repository at this point in the history

  7. Got first better stubs!

    @MichaelFishmanBDAII
    MichaelFishmanBDAII committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9251a39 View commit details
    Browse the repository at this point in the history

  8. doc

    @MichaelFishmanBDAII
    MichaelFishmanBDAII committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    4cbf1d9 View commit details
    Browse the repository at this point in the history