Add an optional list of dependencies that will trigger regeneration when changed #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@corot Do you have a repository I could use to verify this behavior? |
mjcarroll
approved these changes
Sep 11, 2019
|
corot
referenced
this pull request
in naturerobots/move_base_flex
Sep 13, 2019
|
Any progress on this? @mjcarroll, do you need more details or additional information? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to make easier to extract sets of parameters common to a variety of nodes into separated python modules that can be easily incorporated to different cfg files. This can be easily done by importing the common parameters, but the problem is that changing the file defining them will not trigger parameters regeneration; you must trigger it by touching the cfg file!
I use the DEPENDS keyword. Without it, you have the normal behavior.
In this move_base_flex issue I describe my particular uses case.