-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial median filter #201
Spatial median filter #201
Conversation
This reverts commit 16118ea.
…laser_filters into spatial_median_filter
This looks quite useful! I'll take a closer look tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some questions. Also could you add an example yaml and python launch file in the examples folder?
It looks like you've made some changes to address my comments. When you have a chance, could you reply to each review comment to note that you've addressed it, and let me know when this PR is ready for another look? |
Hey @jonbinney , |
Thanks! One more small request: could you add a comment in the code about why the window size needs to be incremented if it is even? Your explanation was good, just copy it into the code there: "If the window_size is even, the current range, which will be modified cannot be centered in the window." Once you do that and add the example files, this should be ready for me to merge. |
…dded comment and warning when ensuring window_size_ is odd
Hello @jonbinney , |
Merging - thanks for contributing this @YBachmann ! |
This PR adds a 1D spatial median filter.
The size of the filter can be set via the parameter
window_size
.In this screenshot you can see the raw laserscan in blue and the result of the spatial median filter in red (
window_size=31
).The filter smoothes the walls and also removes isolated/scattered noise (see e.g. directly right of the robot).