Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add image_flip node #942

Draft
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Draft

add image_flip node #942

wants to merge 2 commits into from

Conversation

mikeferguson
Copy link
Member

This is a continuation of #756:

  • Squashed 16 commits in original PR for ease of rebase/review
  • Moved node into image_rotate package
  • Added lazy subscriber
  • Removes QoS parameters - will add proper QoS overrides in a different PR (when we do the same for image_rotate)
  • Adds documentation

@mikeferguson mikeferguson mentioned this pull request Feb 12, 2024
Closed
@mikeferguson
Copy link
Member Author

After reviewing this closer - I may also make both nodes derive from a base class to avoid so much duplicated code

ahcorde
ahcorde requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR still relevant ? there are some conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde requested changes

Assignees
No one assigned
Labels
ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeferguson @ahcorde