Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stereo calibration using charuco board (backport #976) #1003

Open
wants to merge 3 commits into
base: iron
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 20, 2024

From #972
Doing this first for rolling.

This was a TODO in the repository, opening this PR to add this feature.

  • The main issue why this wasn't possible imo is the way mk_obj_points works. I'm using the inbuilt opencv function to get the points there.
  • The other is a condition when aruco markers are detected they are added as good points, This is fine in case of mono but in stereo these have to be the same number as the object points to find matches although this should be possible with aruco.
    This is an automatic backport of pull request Added stereo calibration using charuco board #976 done by Mergify.

From #972
Doing this first for rolling.

This was a TODO in the repository, opening this PR to add this feature.
- The main issue why this wasn't possible imo is the way `mk_obj_points`
works. I'm using the inbuilt opencv function to get the points there.
- The other is a condition when aruco markers are detected they are
added as good points, This is fine in case of mono but in stereo these
have to be the same number as the object points to find matches although
this should be possible with aruco.

(cherry picked from commit efb9005)

# Conflicts:
#	camera_calibration/src/camera_calibration/calibrator.py
@mergify mergify bot added the conflicts label Jun 20, 2024
Copy link
Author

mergify bot commented Jun 20, 2024

Cherry-pick of efb9005 has failed:

On branch mergify/bp/iron/pr-976
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit efb9005.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   camera_calibration/src/camera_calibration/calibrator.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants