New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't "angle-wrap" non-continuous and prismatic joints #631

Open

philipp1234 wants to merge 1 commit into ros-controls:noetic-devel from TAMS-Group:noetic-devel

philipp1234 commented May 20, 2024

Some of the controllers try to incorrectly "angle-wrap" non-continuous joints.

The problem is most obvious with prismatic joints. Linear positions should not be "wrapped around" like angles.
The issue can also affect revolute joints with joint limits. If the goal position is less than 180° across the joint limit, the robot moves into the joint limit.
When a robot is driven back under soft compliant control, the issue can cause the robot to suddenly hit out into the opposite direction.

The proposed code change seems to fix the issue for our use cases.


fix control of discontinuous joints

6cee5c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment