Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JTC] Sample at t + dT instead of the beginning of the control cycle #1306

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[JTC] Sample at t + dT instead of the beginning of the control cycle #1306

wants to merge 10 commits into from

Commits on Oct 7, 2024

  1. Set update rate in testing controller

    @fmauch
    fmauch committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0dba992 View commit details
    Browse the repository at this point in the history

  2. Tests: Call controller.configure() instead of controller.get_node().c… 

    …onfigure()
    @fmauch
    fmauch committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a96dd54 View commit details
    Browse the repository at this point in the history

  3. Sample trajectory at point t+dT

    @fmauch
    fmauch committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d55fea7 View commit details
    Browse the repository at this point in the history

  4. Update trajectory_controller_tests 

    Since we changed the sampling point we need to adapt the tests.
    @fmauch
    fmauch committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9400838 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'master' into jtc_tdt

    @fmauch
    fmauch authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    777e5a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Sai Kishor Kothakota <[email protected]>
    @fmauch @saikishor
    fmauch and saikishor authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b49a0e5 View commit details
    Browse the repository at this point in the history

  2. set update_period as part of on_configure instead of on_activate

    @fmauch
    fmauch committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bc83608 View commit details
    Browse the repository at this point in the history

  3. Use period instead of update_period_ for the PID feedback

    @fmauch
    fmauch committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8c99198 View commit details
    Browse the repository at this point in the history

  4. Remove non-op line 

    This isn't used anymore and more or less confusing, as actual will not
be desired as long as the robot is moving, which it is here.
    @fmauch
    fmauch committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f5f33a7 View commit details
    Browse the repository at this point in the history

  5. Set default controller update rate parameter to 100 

    Some tests require an update rate of 100 which isn't possible
if the default one is at 10.
    @fmauch
    fmauch committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c4022a2 View commit details
    Browse the repository at this point in the history