Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename get/set_state to get/set_lifecylce_state #1250

Merged

Conversation

mamueluth
Copy link
Member

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.41%. Comparing base (1c4d58e) to head (c03a7f0).
Report is 1 commits behind head on master.

Files Patch % Lines
...ory_controller/src/joint_trajectory_controller.cpp 0.00% 1 Missing and 2 partials ⚠️
...iff_drive_controller/src/diff_drive_controller.cpp 0.00% 0 Missing and 1 partial ⚠️
tricycle_controller/src/tricycle_controller.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1250   +/-   ##
=======================================
  Coverage   80.41%   80.41%           
=======================================
  Files         105      105           
  Lines        9354     9355    +1     
  Branches      819      820    +1     
=======================================
+ Hits         7522     7523    +1     
  Misses       1557     1557           
  Partials      275      275           
Flag Coverage Δ
unittests 80.41% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp 77.01% <0.00%> (ø)
tricycle_controller/src/tricycle_controller.cpp 66.12% <0.00%> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 83.84% <0.00%> (ø)

... and 2 files with indirect coverage changes

@bmagyar bmagyar merged commit ce12694 into ros-controls:master Aug 26, 2024
13 of 19 checks passed
RobertWilbrandt pushed a commit to RobertWilbrandt/ros2_controllers that referenced this pull request Sep 19, 2024
christophfroehlich pushed a commit to christophfroehlich/ros2_controllers that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants