Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RQT-JTC] limits from jtc controlled joints #1146

Merged
merged 4 commits into from
Jun 5, 2024
Merged

[RQT-JTC] limits from jtc controlled joints #1146

merged 4 commits into from
Jun 5, 2024

Conversation

delihus
Copy link
Contributor

@delihus delihus commented May 23, 2024

The further explanation of this issue is here #1131

delihus and others added 3 commits January 11, 2023 14:19
@delihus delihus mentioned this pull request May 23, 2024
Open
christophfroehlich
christophfroehlich approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extracting this change.
I tested it with genuine continuous and revolute joints as well as with a revolute joint missing lower/upper limits -> LGTM

@bmagyar bmagyar merged commit 0ae3e42 into ros-controls:master Jun 5, 2024
3 checks passed
@christophfroehlich
Copy link
Contributor

@Mergifyio backport iron humble

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 26, 2024 •
edited
Loading

backport iron humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 26, 2024
@delihus @mergify
[RQT-JTC] limits from jtc controlled joints (#1146)
6f6ed60 
(cherry picked from commit 0ae3e42)
@mergify mergify bot mentioned this pull request Aug 26, 2024
Merged
mergify bot pushed a commit that referenced this pull request Aug 26, 2024
@delihus @mergify
[RQT-JTC] limits from jtc controlled joints (#1146)
066db65 
(cherry picked from commit 0ae3e42)
@mergify mergify bot mentioned this pull request Aug 26, 2024
Merged
bmagyar pushed a commit that referenced this pull request Aug 28, 2024
@mergify
[RQT-JTC] limits from jtc controlled joints (#1146) (#1274)
9e07ac5
bmagyar pushed a commit that referenced this pull request Aug 29, 2024
@mergify
[RQT-JTC] limits from jtc controlled joints (#1146) (#1273)
d1bb76e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bmagyar bmagyar bmagyar approved these changes

@arne48 arne48 Awaiting requested review from arne48

@destogl destogl Awaiting requested review from destogl

@erickisos erickisos Awaiting requested review from erickisos

@livanov93 livanov93 Awaiting requested review from livanov93

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delihus @christophfroehlich @bmagyar