Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joint Limiters: Saturation (current PR971 - will be renamed) and Soft Limiter #1466

Open
bmagyar opened this issue Apr 1, 2024 · 4 comments
Assignees

Comments

@bmagyar
Copy link
Member

bmagyar commented Apr 1, 2024

  1. PR: Simple Joint Limiter --> Saturation Joint Limiter --> Done in Add Saturation Joint Limiter that uses clamping method #971
    • check ros_control implementation for full functionality
    • add also saturation of the effort interface -->
  2. PR: Parse URDF data and use max_acceleration and max_deceleration from <ros2_control> Tag Parse URDF joint hard limits into the HardwareInfo structure #1472
  3. PR: Integrate joint_limits in ResourceManager
  4. PR: Open PR Proposal for extending URDF with these values
  5. PR: Add Soft Joint Limiter (new PR)
@bmagyar
Copy link
Member Author

bmagyar commented Apr 1, 2024

Related to #744

@saikishor
Copy link
Member

PR: #1472 handles the point 2 of this issue, and there will be another upcoming PR adding the SoftLimits to the HardwareInfo structure

@saikishor
Copy link
Member

saikishor commented Apr 18, 2024

The PR: #1488 adds support for the SoftLimits reading and parsing into the HardwareInfo structure

@saikishor
Copy link
Member

We now have this #1526 that includes the changes of #971 and also modified in such a way that it fits in with the integration into the ResourceManager to be able to enforce limits directly over there.

The integration into the ResourceManager would look something like this : saikishor#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Jazzy
Development

No branches or pull requests

3 participants