Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README section tweaks #761

Merged
merged 6 commits into from
Jan 25, 2024
Merged

README section tweaks #761

merged 6 commits into from
Jan 25, 2024

Conversation

maelle
Copy link
Member

@maelle maelle commented Dec 15, 2023

Fix #700 (added two question)
Fix #701 (there's an item further below on badge tables anyway)

pkg_building.es.Rmd Outdated Show resolved Hide resolved
Copy link
Member

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change.

Co-authored-by: Yanina Bellini Saibene <[email protected]>
@maelle
Copy link
Member Author

maelle commented Dec 21, 2023

@mpadge you might have missed this one

@mpadge
Copy link
Member

mpadge commented Dec 22, 2023

No, sorry, did see it, but I'd like to suggest a few edits. Just haven't had a chance yet. will do as soon as i can,

pkg_building.Rmd Outdated Show resolved Hide resolved
@maelle maelle requested a review from mpadge January 9, 2024 09:00
@maelle
Copy link
Member Author

maelle commented Jan 9, 2024

@mpadge I edited the text, is it good so? Then I'll update the Spanish version. Thank you!

Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, but otherwise great

pkg_building.Rmd Outdated Show resolved Hide resolved
@maelle
Copy link
Member Author

maelle commented Jan 23, 2024

@maurolepore only if you have time and want to 🙏

Copy link
Member

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I only see one "." missing.

pkg_building.es.Rmd Outdated Show resolved Hide resolved
@maelle
Copy link
Member Author

maelle commented Jan 25, 2024

Thank you @maurolepore!!

@maelle maelle merged commit 6c198f7 into main Jan 25, 2024
1 check failed
@maelle maelle deleted the readme branch January 25, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

de-duplicate info about badges in README section improve README recommended structure
4 participants